[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

Erick Velez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 08:12:19 PDT 2023


evelez7 added inline comments.


================
Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:612
+  if (isa<CXXConstructorDecl>(Method)) {
+    Name = Method->getNameAsString();
+    if (dyn_cast<CXXConstructorDecl>(Method)->isExplicit())
----------------
Minor change is here. Since `Name` is now an `std::string`, a cast to `Method`'s DeclContext is no longer needed to bypass the simple identifier assertion from `getName` for StringRefs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157007/new/

https://reviews.llvm.org/D157007



More information about the cfe-commits mailing list