[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

Lu Weining via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 07:15:03 PDT 2023


SixWeining added a comment.

LGTM except a nit.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:20447
-
-Value *CodeGenFunction::EmitLoongArchBuiltinExpr(unsigned BuiltinID,
-                                                 const CallExpr *E) {
----------------
The declaration in `clang/lib/CodeGen/CodeGenFunction.h` should also be deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156866/new/

https://reviews.llvm.org/D156866



More information about the cfe-commits mailing list