[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

Thu Aug 3 05:12:20 PDT 2023

kadircet added inline comments.

================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1939

 std::string HeaderSearch::suggestPathToFileForDiagnostics(
     llvm::StringRef File, llvm::StringRef WorkingDir, llvm::StringRef MainFile,
----------------
sorry I guess my suggestion get distorted a little bit on the way :D

I was actually suggesting to rename `IsSystem` to `IsAngled`, and change the logic in the rest of the code here to look for angled-ness of include search path, rather than system-ness.
As all of the current callers make use of this information to figure out if they should spell the includes with `angles` or `quotes` and set it if the include search dir is either part of angled or system includes.

That way we make sure we're not giving mixed signals out of this function. WDYT?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156704/new/

https://reviews.llvm.org/D156704