[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

Thu Aug 3 00:41:43 PDT 2023

kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136
   case Invalid:
+  case Undefined:
     llvm_unreachable("Unhandled type.");
----------------
4vtomat wrote:
> eopXD wrote:
> > Could we just reuse `Invalid`?
> We can't reuse Invalid, since `ScalarType` in `RVVType` class is default to `Invalid`, we are not able to determine whether it's really invalid or not during `applyModifier` function, so that's the reason why I added `Undefined` to differentiate between `default` and `really invalid`.
I has some question before too :P thanks for explanation!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156223/new/

https://reviews.llvm.org/D156223