[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

Thu Aug 3 00:41:43 PDT 2023

zyounan planned changes to this revision.
zyounan added a comment.

In D155370#4552967 <https://reviews.llvm.org/D155370#4552967>, @nridge wrote:

> I was thinking of functions with different names (with a common prefix) and different signatures, where the signature could be a useful piece of information in addition to the name to help you choose the right one.

Ah, that makes sense! Honestly, I've never thought the signature could assist such a scenario.

> Note, we have a flag that affects this, `--completion-style=detailed`.

Thanks. Just learned this flag.

Apart from the `Signature`, I still have two improvements for `CanBeCall`. I think it's better to close this review and merge these two changes into one patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155370/new/

https://reviews.llvm.org/D155370