[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

[Anton Rydahl via Phabricator via cfe-commits]

AntonRydahl added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:432
+  "Target '%0' does not support exception handling."
+  " To allow code generation for '%0', 'catch' statement will be replaced by a no operation instruction.">;
 }
----------------
jdoerfert wrote:
> Check the style of other messages, they have a single sentence and start with a lower case letter.
> Also, the explanation doesn't make sense for users. They don't know about traps, basic blocks, etc.
> Maybe:
> `target '%0' does not support exception handling; 'throw' is assumed to be never reached`
> `target '%0' does not support exception handling; 'catch' block is ignored`
> and nothing for try.
> Finally, these need a group so users can also disable them.
Is the group name ok? Now the warnings can be enabled with `-Wopenmp-target-exception` and disabled with `-Wno-openmp-target-exception`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153924/new/

https://reviews.llvm.org/D153924