[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Wed Aug 2 12:12:06 PDT 2023

ro added a comment.

In D156363#4554884 <https://reviews.llvm.org/D156363#4554884>, @MaskRay wrote:

> In D156363#4554812 <https://reviews.llvm.org/D156363#4554812>, @jhuber6 wrote:
>
>> 

>> Probably because we're not specifying the `--target=` I'll add that in my fix for AMDGPU I'm working on and see if it solves the problem.
>
> Thank you for fixing these tests. I agree that clang_f_opts.c:117 with `-flto` needs a `--target=`, to not cause this error on `amd64-pc-solaris2.11'`.
> This should be the only line. I unfortunately did not catch this because I do not have access to a target using `HasNativeLLVMSupport` == false`.

Confirmed: adding `-target x86_64-unknown-linux` to both `clang_f_opts.c:117` and `lto.c:19` let both tests `PASS` on `amd64-pc-solaris2.11`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363