[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 2 08:40:51 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:74
+      << "  -U                    - Use actual timestamps and uids/gids\n"
+      << "  -X{32|64|32_64|any}       - Specifies which archive symbol tables "
+         "should be generated if they do not already exist (AIX OS only)\n";
----------------
"Specify". The convention is to use imperative sentences. Also, does the `-` align with `-` above?

(The capitalization is a bit inconsistent. For existing llvm-ranlib options, capitalization is more common.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142660/new/

https://reviews.llvm.org/D142660



More information about the cfe-commits mailing list