[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

Wed Aug 2 08:40:15 PDT 2023

foad added a comment.
Herald added a project: All.

Hi @erik.pilkington, I see this got reverted:

  commit e26c24b849211f35a988d001753e0cd15e4a9d7b
  Author: Erik Pilkington <erik.pilkington at gmail.com>
  Date:   Wed Feb 12 12:02:58 2020 -0800

      Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

      This reverts commit fafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402.

      Should fix ppc stage2 failure: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546

Do you have any more info on the "ppc stage2 failure"? I'd like to pursue something like this patch to get more accurate lifetime markers for temporaries, so that LLVM stack slot coloring can do a better job, and we get smaller stack usage. This is prompted by https://github.com/llvm/llvm-project/issues/41896

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74094/new/

https://reviews.llvm.org/D74094