[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

Wed Aug 2 07:51:44 PDT 2023

RKSimon added inline comments.

================
Comment at: llvm/utils/lit/lit/discovery.py:60
+            cfgpath = util.abs_path_preserve_drive(cfgpath)
+            target = config_map.get(cfgpath)
             if target:
----------------
RKSimon wrote:
> RKSimon wrote:
> > Found the problem - you have moved the os.path.normpath call inside abs_path_preserve_drive, causing the path canonicalization fails - removing it and going back to os.path.normcase(cfgpath) seems to fix the issue - I'll push my fix shortly.
> 5ccfa1568130 fixed my builds but broke this - https://lab.llvm.org/buildbot/#/builders/216/builds/24966
> 
> Any suggestions would be appreciated, but I can't think of anything but reverting both commits until we get to the bottom of it.
Panic over - I think I've fixed this with d6f1880c629d

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154130/new/

https://reviews.llvm.org/D154130