[PATCH] D156205: wasm: link crt1 even in case of -shared

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 2 06:33:36 PDT 2023


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:80
 
-  const char *Crt1 = "crt1.o";
+  bool isCommand = true;
+  const char *Crt1;
----------------
LLCM coding style is `IsCommand` (at last for now: https://llvm.org/docs/Proposals/VariableNames.html)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156205/new/

https://reviews.llvm.org/D156205



More information about the cfe-commits mailing list