[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added a comment.

In D156816#4551500 <https://reviews.llvm.org/D156816#4551500>, @jdoerfert wrote:

> Macros seems to be good enough. If we really need clang attributes, we need new docs, and naming convention etc.

Yeah an alternative would be a new set of attributes, then we make the old ones OpenCL language specific. One problem is that this will probably be copy pasting everything a second time with no difference, but it might be fine. This is just the easy version. Also `addrspace_` probably isn't the best name since there's other non-GPU targets that use address spaces. I just think that this GPU generic stuff should be moved out of OpenCL in whatever way is most convenient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156816/new/

https://reviews.llvm.org/D156816