[PATCH] D151834: Include math-errno with fast-math

Tue Aug 1 07:45:57 PDT 2023

aaron.ballman added inline comments.

================
Comment at: clang/docs/UsersManual.rst:1727

-   * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=on``).  This is the default behavior.
+   * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=on``).  This is the default behavior. This value resets ``-fmath-errno`` to its target-dependent default.
    * ``strict`` Enables ``-frounding-math`` and ``-ffp-exception-behavior=strict``, and disables contractions (FMA).  All of the ``-ffast-math`` enablements are disabled. Enables ``STDC FENV_ACCESS``: by default ``FENV_ACCESS`` is disabled. This option setting behaves as though ``#pragma STDC FENV_ACCESS ON`` appeared at the top of the source file.
----------------
zahiraam wrote:
> aaron.ballman wrote:
> > Can you re-flow this to 80 columns?
> Did the same for the rest of the text too. Is that OK?
Yeah, that's not the end of the world (if it was touching the whole file, that should be done as an NFC change outside of this patch, but these changes are related enough I think it's fine to do in this patch).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151834/new/

https://reviews.llvm.org/D151834