[PATCH] D146023: [AMDGPU] Remove Code Object V2

[Pierre van Houtryve via Phabricator via cfe-commits]

Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5583
 
+  // FIXME: Shouldn't be needed anymore? Should we remove this directive
+  // entirely? See `amdpal-elf.ll` - the output ASM contains both amdgcn_target
----------------
This is an issue with `amdpal-elf.ll`, the run line with `llvm-mc` fails because it can't parse `amd_amdgpu_isa`.
Not sure how to fix this. Should we be able to read that directive, or should we just never emit it?
Some tests use it, and stg also emits it in the same test, so it's not new. It's just no longer parse-able after `isHsaAbiVersion3AndAbove` was removed - I suspect that function returned false for non-HSA OSes and was mistakenly used here to check for `!= AMDHSA`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146023/new/

https://reviews.llvm.org/D146023