[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

[Nathan Ridge via Phabricator via cfe-commits]

nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1432
 
 TEST(TypeHints, SubstTemplateParameterAliases) {
+  llvm::StringRef Header = R"cpp(
----------------
zyounan wrote:
> I feel like this test is becoming clunky: The validations here require an invented class template `vector` which I think should be better placed in a header; however, in the remaining snippet, it seems that I'm testing too many hints in one `assertHint` call. Should I split these cases into different snippets, or we just leave them as-is at the moment?
I think this is fine as-is for now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156300/new/

https://reviews.llvm.org/D156300