[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

Mon Jul 31 14:21:38 PDT 2023

bob80905 added a comment.

I think you need to mention this new builtin in clang/docs/ReleaseNotes.rst.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2548
+    case Builtin::BI__builtin_sqrtf128:
+    case Builtin::BI__builtin_elementwise_sqrt: {
       llvm::Value *Call = emitUnaryMaybeConstrainedFPBuiltin(
----------------
Nit: I think despite this code working, it should be moved to be grouped with the other elementwise builtins at around line 3240.
Consider BI__builtin_log at around 2436 and the other log builtins, the bultin_elementwise_log builtin is not in that group since it's with the other elementwise builtins. Writing this case here would make an inconsistency with the placement of the other elementwise builtins.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156737/new/

https://reviews.llvm.org/D156737