[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

The CU's DIFile is conjured up in CGDebugInfo::CreateCompileUnit(), and the name is derived from `-main-file-name` rather than anything SourceManager provides. Although there is a comment wondering about that. CreateCompileUnit() computes a checksum for that DIFile, but apparently the DIFile never makes it into the DIFileCache.

DIFileCache is generated by CGDebugInfo::createFile(); it looks like there are some subtle differences in the path handling between what it does and what CreateCompileUnit() does, so making CreateCompileUnit() go through createFile() might not the the right thing. But it does look like CreateCompileUnit() might just be missing a one-liner to add the CU's DIFile to DIFileCache.

I'll try that instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156571/new/

https://reviews.llvm.org/D156571