[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

Mon Jul 31 10:10:44 PDT 2023

cjdb added inline comments.

================
Comment at: clang/lib/Sema/SemaType.cpp:5930-5931
       break;
+    case DeclaratorContext::Member:
+      // Expand for packed data members.
     case DeclaratorContext::TemplateParam:
----------------
dblaikie wrote:
> Perhaps a few more words here would be good - quoting a WG21 proposal paper that this code implements, similar to the standard quotations in nearby code. (be good to mention the WG21 proposal paper/whatnot in the patch description/commit message too)
I would suggest a link to the discourse discussion instead of [[ http://wg21.link/P1858 | P1858]], since that thread talks about the proposal and goes into a bit more detail than the [[ https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1858r2.html#member-packs | member packs ]] section of the proposal.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156546/new/

https://reviews.llvm.org/D156546