[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 31 10:05:56 PDT 2023


steven_wu added inline comments.


================
Comment at: llvm/lib/TargetParser/LoongArchTargetParser.cpp:19
 
+StringRef Arch;
+StringRef TuneCPU;
----------------
Why do we store `Arch` and `TuneCPU` as globals? We should not have as little global state in compiler as possible. Any reason why they are not stored in `LoongArchTargetInfo` instead like other Targets?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155824/new/

https://reviews.llvm.org/D155824



More information about the cfe-commits mailing list