[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 31 08:48:47 PDT 2023


dgoldman created this revision.
dgoldman added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.

All callers will use the IsSystem flag to decide whether to use <> or ""
style includes, so we treat all frameworks as System since by convention
they use <> style includes.

Also update clangd's custom logic for frameworks accordingly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156704

Files:
  clang-tools-extra/clangd/index/SymbolCollector.cpp
  clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp
  clang/lib/Lex/HeaderSearch.cpp
  clang/unittests/Lex/HeaderSearchTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156704.545692.patch
Type: text/x-patch
Size: 8094 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230731/782bfd85/attachment.bin>


More information about the cfe-commits mailing list