[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

[Takuya Shimizu via Phabricator via cfe-commits]

hazohelet updated this revision to Diff 545582.
hazohelet added a comment.

Address review comments

- Print the character representation only when the type of the expressions is `char` or `char8_t`
- Use `pushEscapedString` in the printing so that we can reuse its escaping logic
- Use `escapeCStyle` to escape whitespace characters
- `wchar_t` and `charN_t` are not handled yet


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155610/new/

https://reviews.llvm.org/D155610

Files:
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Basic/Diagnostic.h
  clang/lib/Basic/Diagnostic.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/test/Lexer/cxx1z-trigraphs.cpp
  clang/test/SemaCXX/static-assert-cxx26.cpp
  clang/test/SemaCXX/static-assert.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155610.545582.patch
Type: text/x-patch
Size: 7655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230731/ad00cc80/attachment-0001.bin>