[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D156363#4545474 <https://reviews.llvm.org/D156363#4545474>, @MaskRay wrote:

> In D156363#4545215 <https://reviews.llvm.org/D156363#4545215>, @dyung wrote:
>
>> If you cannot reproduce this issue, I can take my buildbot offline and try to reproduce it to pinpoint which command is causing the problem, but I won’t be able to do so until Monday.
>
> Thank you, knowing which command caused the failure will be very helpful.
> `clang/test/Driver/fsanitize.c` has the most mysterious failure I have dealt with for this patch.
>
> FWIW I've checked that the test passes even if `/usr` does not exist (emulated by proot) => there is as if no host GCC installation that could affect Driver's behavior
>
>   % cat /tmp/Rel/bin/xxx
>   #!/bin/zsh
>   d=$(dirname "$0")
>   exec proot -R /tmp -b /bin -b /lib64 -b /lib $d/clang --target=aarch64-linux-musl "$@"
>   % cd clang/test/Driver
>   % CLANG=/tmp/Rel/bin/xxx /tmp/Rel/bin/llvm-lit -vv fsanitize.c
>   .. passed

I have to run, but I did a quick -vv run with this commit and it seems to fail on the RUN line on 588:

  + : 'RUN: at line 581'
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang --target=i386-apple-ios-simulator -fsanitize=leak /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c -###
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c --check-prefix=CHECK-LSAN-I386-IOSSIMULATOR
  + : 'RUN: at line 584'
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang --target=i386-apple-tvos-simulator -fsanitize=leak /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c -###
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c --check-prefix=CHECK-LSAN-I386-TVOSSIMULATOR
  + : 'RUN: at line 588'
  + not /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/clang --target=x86_64-linux-gnu -fvisibility=hidden -fsanitize=cfi -flto -c /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c -###
  + /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/clang/test/Driver/fsanitize.c --check-prefix=CHECK-CFI
  
  --
  
  ********************
  ********************
  Failed Tests (1):
    Clang :: Driver/fsanitize.c

I'll try to look more later when I get more time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363