[PATCH] D156650: [clangd] Respect IWYU keep pragma for standard headers.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 31 01:50:07 PDT 2023


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!



================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:85-86
   if (PI) {
     if (PI->shouldKeep(Inc.HashLine + 1))
       return false;
     // Check if main file is the public interface for a private header. If so we
----------------
can you unify this and the previous check and just have a single:
```
if (PI && PI->shouldKeep(Inc.HashLine + 1))
  return false;
```

at the top of the function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156650/new/

https://reviews.llvm.org/D156650



More information about the cfe-commits mailing list