[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D156363#4544803 <https://reviews.llvm.org/D156363#4544803>, @aaron.ballman wrote:

> In D156363#4544782 <https://reviews.llvm.org/D156363#4544782>, @thakis wrote:
>
>> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this something on my end?
>
> Nope, this same failure is happening in our build farm:
> https://lab.llvm.org/buildbot/#/builders/197/builds/8677
> https://lab.llvm.org/buildbot/#/builders/179/builds/6872
> https://lab.llvm.org/buildbot/#/builders/198/builds/4171
>
> (and others)

`test/Driver/fsanitize.c` contains many `%clang` RUN lines. Presumably one somehow exits with code 1 , but without using `llvm-lit -vv` we don't know which command fails, making this almost impossible to investigate...

I guess adding `--dump-input=fail` to every FileCheck command will be useful as well but it would cluster up the history of `fsanitize.c`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363