[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

Sun Jul 30 00:10:06 PDT 2023

4vtomat added a comment.

In D154576#4483919 <https://reviews.llvm.org/D154576#4483919>, @lhtin wrote:

> In D154576#4476300 <https://reviews.llvm.org/D154576#4476300>, @4vtomat wrote:
>
>> In D154576#4476291 <https://reviews.llvm.org/D154576#4476291>, @craig.topper wrote:
>>
>>> Does this only change the calling convention when `__attribute__((riscv_vector_cc))` is used? The attribute should be mentioned in the patch description.
>>
>> Yes it only changes when `__attribute__((riscv_vector_cc))` is used, thanks for reminding, I will mention in the description.
>
> In addition to using attributes, functions that use vector registers to pass arguments or return values also need to comply with the new calling convention.

Thanks for pointing this out! However, since it would make a tons of test cases change, I will make it in another patch!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154576/new/

https://reviews.llvm.org/D154576