[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

[Nathan Ridge via Phabricator via cfe-commits]

nridge added inline comments.


================
Comment at: clang/lib/Index/IndexBody.cpp:150
+                                    ParentDC,
+                                    unsigned(SymbolRole::NameReference));
+  }
----------------
ckandeler wrote:
> kadircet wrote:
> > nridge wrote:
> > > `NameReference` was introduced in https://github.com/llvm/llvm-project/commit/e7eb27a9a0edd859de49bcc9af7ca27dbb435886 to handle the somewhat unique situation with constructors and destructors where the constructor/destructor references the class by name but semantically denotes a separate entity.
> > > 
> > > Why is that applicable here?
> > > 
> > > Note that `handleReference()` will automatically add `SymbolRole::Reference` [here](https://searchfox.org/llvm/rev/cea72fe34194d58ac1ba9485ee9c9a63cf98a4e6/clang/lib/Index/IndexingContext.cpp#404).
> > +1 we shouldn't be setting namereference here.
> So set nothing at all here?
Yes, I think we should pass a default constructed `SymbolRoleSet()` here, and `handleReference()` will add `SymbolRole::Reference` into it automatically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150124/new/

https://reviews.llvm.org/D150124