[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 28 18:06:10 PDT 2023


tejohnson marked 2 inline comments as done.
tejohnson added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:83
+!4 = !{i32 1, !"wchar_size", i32 4}
+!5 = !{i32 8, !"PIC Level", i32 2}
+!6 = !{i32 7, !"PIE Level", i32 2}
----------------
aeubanks wrote:
> the debug info is necessary for sample profile to work I presume?
> 
> I think some of this can still be simplified, like `PIC Level`, etc
Right, that's need for SamplePGO. Removed the other stuff that wasn't necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155997/new/

https://reviews.llvm.org/D155997



More information about the cfe-commits mailing list