[PATCH] D156565: Diagnose use of VLAs in C++ by default

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added subscribers: ABataev, clang-vendors.
aaron.ballman added a comment.

The patch seems large and scary, but that's because of how often we've had to test VLA behavior in C++ code. The OpenMP test cases are mostly opting out of VLA warnings mechanically (I verified with @ABataev that this was the desired approach) while the non-OpenMP tests were largely updated by hand so that I could spot check the diagnostic behavior to ensure it's reasonable. The functional changes themselves are quite small.

Adding the clang-vendors group in case this is disruptive for downstreams.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156565/new/

https://reviews.llvm.org/D156565