[PATCH] D105759: Implement P2361 Unevaluated string literals

Fri Jul 28 11:23:12 PDT 2023

aaron.ballman added a comment.

In D105759#4543184 <https://reviews.llvm.org/D105759#4543184>, @hubert.reinterpretcast wrote:

> In D105759#4541813 <https://reviews.llvm.org/D105759#4541813>, @cor3ntin wrote:
>
>> In D105759#4540716 <https://reviews.llvm.org/D105759#4540716>, @hubert.reinterpretcast wrote:
>>
>>>> I hope this patch may allow to gather some data on that.
>>>
>>> @cor3ntin, I have reports that applications having encoding prefixes in `static_assert` are failing to build. The committee did not adopt the subject paper as a "DR resolution". Is it possible to downgrade to a warning?
>>
>> You know how frequent it is?
>
> No, but I am concerned that this came up even before we deployed an LLVM 17-based solution (in pre-release testing). I believe that reverting for LLVM 17 is the prudent course of action.

Early reports of user code getting tripped up on this is something we should react to while we still can; I'd recommend we change the diagnostic to be a warning that defaults to an error so that users who are caught by the changes can still disable the diagnostic rather than be stuck; for Clang 18, we can explore other solutions to the issue. Would this work for you @hubert.reinterpretcast?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105759/new/

https://reviews.llvm.org/D105759