[PATCH] D156492: [clang][deps] Make the C++ API more type-safe

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 28 11:21:29 PDT 2023


benlangmuir accepted this revision.
benlangmuir added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:175
   std::vector<PrebuiltModuleDep> PrebuiltModuleDeps;
-  llvm::MapVector<std::string, ModuleDeps, llvm::StringMap<unsigned>>
+  llvm::MapVector<ModuleID, ModuleDeps, llvm::DenseMap<ModuleID, unsigned>>
       ClangModuleDeps;
----------------
You can drop the third template argument; it now matches the default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156492/new/

https://reviews.llvm.org/D156492



More information about the cfe-commits mailing list