[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 28 09:08:28 PDT 2023


arsenm added a comment.

In D156539#4542836 <https://reviews.llvm.org/D156539#4542836>, @rjmccall wrote:

> We should probably write this code to work properly in case we add a target that makes `__builtin_alloca` return a pointer in the private address space.  Could you recover the target AS from the type of the expression instead of assuming `LangAS::Default`?

This should happen for opencl today with amdgpu


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156539/new/

https://reviews.llvm.org/D156539



More information about the cfe-commits mailing list