[PATCH] D156368: [OpenMP] Do not always emit unused extern variables

[Shilei Tian via Phabricator via cfe-commits]

tianshilei1992 added a comment.

I think this is reasonable.



================
Comment at: clang/test/OpenMP/declare_target_codegen.cpp:264
-// CHECK-DAG: !{i32 1, !"aaa", i32 0, i32 {{[0-9]+}}}
-// CHECK-DAG: !{i32 1, !"ccc", i32 0, i32 {{[0-9]+}}}
 // CHECK-DAG: !{{{.+}}virtual_foo
----------------
Since `ccc` is used here, it is not supposed to be removed right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156368/new/

https://reviews.llvm.org/D156368