[PATCH] D156542: [Clang] Fix constexpr alloc tests on 32 bits platforms
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 28 07:19:46 PDT 2023
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Some bots were broken by 45ab2b48bd55 <https://reviews.llvm.org/rG45ab2b48bd55e50a86f6026ed31d2b60a118bdce>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156542
Files:
clang/test/SemaCXX/cxx2a-constexpr-dynalloc-limits.cpp
Index: clang/test/SemaCXX/cxx2a-constexpr-dynalloc-limits.cpp
===================================================================
--- clang/test/SemaCXX/cxx2a-constexpr-dynalloc-limits.cpp
+++ clang/test/SemaCXX/cxx2a-constexpr-dynalloc-limits.cpp
@@ -42,12 +42,15 @@
T* data;
};
-constexpr std::size_t s = S<std::size_t>(1099511627777)[42]; // expected-error {{constexpr variable 's' must be initialized by a constant expression}} \
- // expected-note@#call {{in call to 'this->alloc.allocate(1099511627777)'}} \
- // expected-note@#alloc {{cannot allocate array; evaluated array bound 1099511627777 is too large}} \
- // expected-note {{in call to 'S(1099511627777)'}}
+// Only run these tests on 64 bits platforms
+#if __LP64__
+constexpr std::size_t s = S<std::size_t>(~0UL)[42]; // expected-error {{constexpr variable 's' must be initialized by a constant expression}} \
+ // expected-note-re@#call {{in call to 'this->alloc.allocate({{.*}})'}} \
+ // expected-note-re@#alloc {{cannot allocate array; evaluated array bound {{.*}} is too large}} \
+ // expected-note-re {{in call to 'S({{.*}})'}}
+#endif
// Check that we do not try to fold very large arrays
-std::size_t s2 = S<std::size_t>(1099511627777)[42];
+std::size_t s2 = S<std::size_t>(~0UL)[42];
std::size_t s3 = S<std::size_t>(~0ULL)[42];
// We can allocate and initialize a small array
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156542.545153.patch
Type: text/x-patch
Size: 1617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230728/a97c8088/attachment-0001.bin>
More information about the cfe-commits
mailing list