[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 28 07:16:28 PDT 2023


doru1004 added a comment.

In D154568#4528274 <https://reviews.llvm.org/D154568#4528274>, @efwright wrote:

> Dropping off a simple test case. If this looks about what you would expect for the tests I have a couple more involved ones that I can repurpose and add in. For more complex tests we have a couple of the benchmark codes from ICPP that were working.
>
> Some cleanup of the code gen is coming, will be on travel tomorrow so might take a day or two.

If you want to do this properly you need to have tests for various ways in which the simd directive can be used in combination with other directives. I am actually surprised you haven't had to modify any of the existing lit tests that involve the simd directive. Do you know why that is? Is it because you're not doing anything other than running sequentially?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154568/new/

https://reviews.llvm.org/D154568



More information about the cfe-commits mailing list