[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

Fri Jul 28 06:45:16 PDT 2023

aaron.ballman added a comment.

In D155546#4541144 <https://reviews.llvm.org/D155546#4541144>, @tbaeder wrote:

> Thanks for the info @jcranmer-intel.
>
> I see that the current intepreter doesn't check this for `__builtin_fmin`(GCC does) either, but it does error out for e.g. `__builtin_nan("") + 1` (GCC doesn't).
>
> @aaron.ballman I'd like to handle that in a separate patch where I also handle regular floating point operations.

I think that's reasonable.

In D155546#4541249 <https://reviews.llvm.org/D155546#4541249>, @tbaeder wrote:

> As for signaling vs. quiet NaNs, it seems like both GCC and Clang only check for NaNs, and don't care if it's signaling or not.

Yeah, I'm not too surprised that we missed these kinds of "edge" cases.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155546/new/

https://reviews.llvm.org/D155546