[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D156363#4539877 <https://reviews.llvm.org/D156363#4539877>, @dblaikie wrote:

> FWIW this sounds good to me (though given how wide the patch is, might be worth waiting a few days to a week in case anyone else has thoughts).
>
> I only looked at a sample of the test changes - if there's anything much more interesting than adding `not` to any tests, might be worth calling those out in the description/review/etc - and maybe discuss what to do with `not`s that are added but because the test is buggy/mistaken. Them being explicit may confuse future users into thinking they're intentional, rather than pragmatic. Don't really know what to do about that - probably nothing.

Thanks for the feedback! I used a script to automatically add `not` to failing `%clang` tests and manually fixed some `env PATH=... %clang` style tests that my script cannot handle.

I noticed  `debug-options.c` had incorrect RUN lines from D54487 <https://reviews.llvm.org/D54487> but fixed the test separately, and some AMDGPU tests might be better fixed by adding `-nogpulib`, otherwise there should likely be no tests that require specialized treatment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363