[PATCH] D156093: [ASTImporter] Re-odering by lexical order for all imported decls within record

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 19:15:10 PDT 2023


shafik added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:1950
+        ToD && ToDC == ToD->getLexicalDeclContext() &&
+        ToDC->containsDecl(ToD)) {
+      ToDC->removeDecl(ToD);
----------------
If `ToDC` does not contain the decl is that a problem, what case do we expect this to happen? Do we test that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156093/new/

https://reviews.llvm.org/D156093



More information about the cfe-commits mailing list