[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)
Galen Elias via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 27 18:30:42 PDT 2023
galenelias added a comment.
In D150403#4539874 <https://reviews.llvm.org/D150403#4539874>, @owenpan wrote:
> This seems to cause a regression. See https://github.com/llvm/llvm-project/issues/64134. @galenelias any idea?
I will take a look. The logic I added is trying to distinguish `{ } {` by looking at the token prior to the first l_brace, and checking if it's an identifier to quantify this as a braced list brace. In this case, it's actually a `>`, so the code decides it's a scope brace instead.
I could easily patch it to also allow for a `>`, but don't want this to devolve into a long trail of hacks either. Let me think about it a bit more, and I'll come up with a forward fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150403/new/
https://reviews.llvm.org/D150403
More information about the cfe-commits
mailing list