[PATCH] D156452: [clang-tidy] Sort options in --dump-config

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 10:38:16 PDT 2023


PiotrZSL marked 3 inline comments as done.
PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:90
+    std::vector<std::pair<StringRef, StringRef>> SortedOptions;
+    SortedOptions.reserve(Options.size());
+    for (auto &Key : Options) {
----------------
carlosgalvezp wrote:
> I believe you can pass this directly to the constructor in the previous line, to skip the `reserve()` part.
No, constructor takes `resize` argument, not `reserve`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156452/new/

https://reviews.llvm.org/D156452



More information about the cfe-commits mailing list