[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

Thu Jul 27 10:15:57 PDT 2023

aaron.ballman added a comment.

In D156274#4539522 <https://reviews.llvm.org/D156274#4539522>, @schittir wrote:

> Thank you for the review, @aaron.ballman and @efriedma
> Do you recommend any changes here?

The changes to SemaCodeComplete.cpp and ItaniumMangle.cpp are good, the changes in CGObjCMac.cpp require some more work because the static analysis tool found a real bug and we should fix the bug rather than assert it won't be hit. I'd recommend landing the good changes now (they're NFC) and start a new review for the codegen changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156274/new/

https://reviews.llvm.org/D156274