[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

Sylvain Audi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 08:44:15 PDT 2023


saudi abandoned this revision.
saudi added a comment.
Herald added a project: All.

In D102633#2786288 <https://reviews.llvm.org/D102633#2786288>, @aganea wrote:

> @dexonsmith Yes, using the Clang Tooling C++ API seems like a good option, however some logic could/would be needed from `clang/tools/clang-scan-deps/ClangScanDeps.cpp`. Using clang-scan-deps as-a-DLL seemed like the best option on the short term, since we're using its `main()` //almost// verbatim with only a few minor changes. We still need to solve a contention issue related to the Windows implementation of `sys::fs::status()`, but then once everything is sorted out we'll re-consider the usage of the DLL.

Abandonning this patch, since we ended up creating a separate tool based on ClangScanDeps, modified and simplified for our needs: builds as a DLL, no `-j #` support as the main function is itself called from different threads, etc...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102633/new/

https://reviews.llvm.org/D102633



More information about the cfe-commits mailing list