[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Nikolas Klauser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 07:54:37 PDT 2023


philnik added a comment.

In D156247#4538626 <https://reviews.llvm.org/D156247#4538626>, @aaron.ballman wrote:

> I would like explicit buy-in from the libc++ folks on the idea of adding `-fno-coroutines` as they're going to be impacted by Clang supporting such an option (and they may have additional testing requirements to ensure that libc++ works reasonably well when coroutines are disabled).

I don't think we want to support having another flag for a dialect, since that will result in more problems down the road. We already have a problem with the number of configurations we support and adding style-guide configurations won't help that. IMO this should just be a clang-tidy check. They can be enforced just as well as compiler warnings/errors, and don't cause problems for other people.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156247/new/

https://reviews.llvm.org/D156247



More information about the cfe-commits mailing list