[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

Thu Jul 27 07:01:30 PDT 2023

aaron.ballman added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:60
+          "'external_source_symbol' attribute|"
+          "as argument of '%1' attribute}0">;
+
----------------
cor3ntin wrote:
> aaron.ballman wrote:
> > This duplicates part of `err_attribute_argument_type`; probably worth it to update that diagnostic so we get consistent diagnostic wording between attributes expecting string literal arguments.
> I'm not sure there is a good way to do that without changing thousands of tests. I did look into it!
If it's a slog, it can be done in a follow-up as an NFC commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156237/new/

https://reviews.llvm.org/D156237