[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 06:46:23 PDT 2023


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/include/clang/Driver/Driver.h:712
+  /// Whether there are HIP input files.
+  bool hasHIPInputs() const { return HasHIPInputs; }
+
----------------
jhuber6 wrote:
> Shouldn't we have access to the compilation? I figured we could check `C.getActiveOffloadKinds()` or w/e it's called.
yes that is a better solution. will do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156426/new/

https://reviews.llvm.org/D156426



More information about the cfe-commits mailing list