[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

LGTM! I'm excited to learn what this new facility discovers!



================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1730-1735
+#ifndef NDEBUG
+#define DEBUG_NOTE_DECL_FAIL(D, Msg)  \
+Handler.addDebugNoteForVar((D), (D)->getBeginLoc(), "failed to produce fixit for declaration '" + D->getNameAsString() + "'" + Msg)
+#else
+#define DEBUG_NOTE_DECL_FAIL(D, Msg)
+#endif
----------------
An extra bit of paranoia.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154880/new/

https://reviews.llvm.org/D154880