[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 26 14:59:52 PDT 2023


arsenm added a comment.

We should just do this now. clang shouldn't have to dig around on disk to emit a constant definition for a constant it already knows, and we have a clear path to removing these globals altogether. I have adequate patches to completely delete `__oclc_daz_opt` today. `__oclc_finite_only_opt` should be deleteable as soon as nofpclass is inferred by default. Deleting `__oclc_correctly_rounded_sqrt32` and `__oclc_unsafe_math_opt` require more work, but are basically the same thing and require extending the libcall optimizer pass.

It will be easier to delete these from the library as they become unnecessary if clang stops enforcing these files exists like it does today, and it's easier to just stop using them entirely than to delete them one at a time


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096



More information about the cfe-commits mailing list