[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 26 14:40:21 PDT 2023


MaskRay added a comment.

@jhuber6 @yaxunl you may want to revise some AMDGPU related tests, e.g. `amdgcn-gz-options.cl`.
Some `RUN: %clang` lines currently fail with `error: cannot find ROCm device library; provide its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build without ROCm device library`.
They likely need `-nogpulib` to stop them from depending on the `-###` quirk (exit code 0), which is going to be fixed by this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156363/new/

https://reviews.llvm.org/D156363



More information about the cfe-commits mailing list