[PATCH] D156330: [hexagon] restore library path arguments

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Tip: use `%clang -fdriver-only -Werror -v` to test that a command produces no warning or error and has an exit code of 0. Without it your `Args.ClaimAllArgs(options::OPT_L);` change is untested.



================
Comment at: clang/test/Driver/hexagon-toolchain-linux.c:123
+
+// RUN: %clang -### -target hexagon-unknown-linux \
+// RUN:   -L /tmp \
----------------
`-target ` has been deprecated since Clang 3.4. Prefer `--target=` for new tests.
I think you can place `%s` on this `%clang ...` line.


================
Comment at: clang/test/Driver/hexagon-toolchain-linux.c:125
+// RUN:   -L /tmp \
+// RUN:   %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK010 %s
----------------
too early wrapping?


================
Comment at: clang/test/Driver/hexagon-toolchain-linux.c:129
+// CHECK010-NOT: warning:
+// CHECK010:   -L/tmp
----------------
Prefer quoting driver's cc1 output, `"-L/tmp"`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156330/new/

https://reviews.llvm.org/D156330