[PATCH] D155213: [HIP] Add `-fno-offload-uniform-block`

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 26 07:10:37 PDT 2023


yaxunl added a comment.

ping

I renamed the option as `-fno-offload-uniform-block`. I switched to `offload` instead of `gpu` because I think in the long run offloading toolchains are not limited to GPUs, therefore sooner or later we will feel `-fgpu-` options are awkward. I did not use `--no-offload-uniform-block` because Options.td does not allow marshalling `--` prefixed options. It needs considerable change to some basic multiclass to achieve that and that would break quite a few established conventions. Therefore I feel it is better to follow the convention.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155213/new/

https://reviews.llvm.org/D155213



More information about the cfe-commits mailing list