[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

[Jon Phillips via Phabricator via cfe-commits]

jp4a50 marked 2 inline comments as done.
jp4a50 added inline comments.


================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:263
   State.StartOfStringLiteral = 0;
+  State.NoLineBreak = false;
   State.StartOfLineLevel = 0;
----------------
HazardyKnusperkeks wrote:
> Was this uninitialized?
It's a new member variable I added as part of this diff.


================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:664-666
+    if ((Style.Language == FormatStyle::LK_Cpp ||
+         Style.Language == FormatStyle::LK_ObjC) &&
+        !Current.is(tok::comment) && PrevNonComment &&
----------------
HazardyKnusperkeks wrote:
> Could move this out of the lambda.
Not sure exactly what you're referring to here. Initialization of `PrevNonComment`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156259/new/

https://reviews.llvm.org/D156259